Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave spare memory for samtools sort (again) #330

Closed
wants to merge 2 commits into from
Closed

Leave spare memory for samtools sort (again) #330

wants to merge 2 commits into from

Conversation

suhrig
Copy link

@suhrig suhrig commented Jul 18, 2023

This PR fixes #81 (again). It was originally fixed in #82, but this fix got lost apparently when splitting the configuration into modules.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

ewels
ewels requested changes Jul 31, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change must be done upstream, in the nf-core/modules repository. Once done there it can be brought back into this pipeline.

@ewels
Copy link
Member

ewels commented Jul 31, 2023

In fact, it's already been fixed upstream: nf-core/modules#3480

so we just need to run nf-core modules update to pull in those changes.

@ewels
Copy link
Member

ewels commented Jul 31, 2023

Updated module in #333 - closing this PR in favour of that.

@ewels ewels closed this Jul 31, 2023
@suhrig
Copy link
Author

suhrig commented Jul 31, 2023

Great, thanks for taking care of it!

@suhrig
Copy link
Author

suhrig commented Oct 19, 2023

Does assigning it to me mean I need to take some action? Isn't this done now?

@bc2zb bc2zb mentioned this pull request Jun 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels requested changes

Assignees

@suhrig suhrig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suhrig @ewels